Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing headers in math/base/special/fast/pow-int and math/base/special/bernoulli #1958

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

performant23
Copy link
Contributor

This commit adds the missing headers in the respective packages.

Description

What is the purpose of this pull request?

This very short PR adds the necessary headers so that the compiler recognizes the types correctly without behaving unexpectedly for any cases

Related Issues

Does this pull request have any related issues?

N/A

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

…bernoulli

This commit adds the missing headers in the respective packages.
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 19, 2024
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why this didn't throw error to me locally, thanks for catching this!

@Pranavchiku Pranavchiku added C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 19, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @performant23!

@kgryte kgryte merged commit 7c8d0ce into stdlib-js:develop Mar 19, 2024
7 checks passed
@kgryte kgryte changed the title fix: missing headers in math/base/fast/pow-int and math/base/special/bernoulli fix: missing headers in math/base/fast/pow-int and math/base/special/bernoulli Mar 19, 2024
@kgryte kgryte changed the title fix: missing headers in math/base/fast/pow-int and math/base/special/bernoulli fix: missing headers in math/base/special/fast/pow-int and math/base/special/bernoulli Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants